Hello,
On Sat, Jan 08, 2005 at 11:43:25AM +0100, Magnus Therning wrote:
> http://www.gnu.org/software/ac-archive/htmldoc/ac_define_dir.html
This code contains the following:
ifelse($3, ,
AC_DEFINE_UNQUOTED($1, "$ac_define_dir"),
AC_DEFINE_UNQUOTED($1, "$ac_define_dir", $3))
First, the `$3' argument is underquoted. It is a description, so it could
easily contain a comma. Second, I see no need for the `ifelse'.
So I propose the patch attached to this mail.
BTW: what does it mean that the macro is in the legacy section of the CVS?
Regards,
Stepan
2005-01-10 Stepan Kasal <kasal@xxxxxx>
* legacy/misc/ac_define_dir.m4: Small cleanup.
Index: legacy/misc/ac_define_dir.m4
===================================================================
RCS file: /cvsroot/ac-archive/ac-archive/legacy/misc/ac_define_dir.m4,v
retrieving revision 1.4
diff -u -r1.4 ac_define_dir.m4
--- legacy/misc/ac_define_dir.m4 28 Oct 2003 22:50:09 -0000 1.4
+++ legacy/misc/ac_define_dir.m4 10 Jan 2005 14:28:40 -0000
@@ -22,9 +22,6 @@
test "x$exec_prefix" = xNONE && exec_prefix='${prefix}'
ac_define_dir=`eval echo [$]$2`
ac_define_dir=`eval echo [$]ac_define_dir`
- $1="$ac_define_dir"
- AC_SUBST($1)
- ifelse($3, ,
- AC_DEFINE_UNQUOTED($1, "$ac_define_dir"),
- AC_DEFINE_UNQUOTED($1, "$ac_define_dir", $3))
+ AC_SUBST($1, "$ac_define_dir")
+ AC_DEFINE_UNQUOTED($1, "$ac_define_dir", [$3])
])
_______________________________________________
Autoconf mailing list
Autoconf@xxxxxxx
http://lists.gnu.org/mailman/listinfo/autoconf
