R P Herrold wrote:
>Thinking about this fragemnt:
>
>+ syslog_facility = LOG_USER Syslog message facility
>+ syslog_priority = LOG_INFO Syslog message priority
>
>I wonder if it should be hardcoded, or merely defaulted and
>over-rideable in the yum.conf file. Possibly validation that
>a permitted value from the facility and priority lists from
>man 5 syslog.conf (possible by populating a pair of allowable
>values, and verifying that a yum.conf value exists in that
>particular array)
>
>
It's there already, same names for yum.conf. Though now it takes only
numbers which is not as convenient. Something like this might be better:
if isinstance(self._getoption('main','syslog_facility'),int):
self.syslog_facility=self._getoption('main','syslog_facility')
else:
self.syslog_facility=eval('syslog.' +
self._getoption('main','syslog_facility'))
....
This way it would accept symbolic names.
Josko P.
