*Troy cheers Seth loudly* YES!!! Good Job! Preliminary tests show that it works. (Preliminary meaning it works on the one machine I've tested it on) I'll get it packaged more formally for here and try it on more machines later today. Thanks Seth And actually a double thanks for working so late on it. Troy seth vidal wrote: > Hi all, > got it! > > so when you loop through a list of archs and you're trying to see if > you've matched any/all of them- its a good idea to NOT exit the loop if > it fails the first time through. > > so I've got a new daily tarball up that I'd like y'all to try out. > > the patch is attached to this mail and its included in: > > http://www.dulug.duke.edu/yum/download/yum-20020925.tar.gz > > > it makes my test case work and I think it will work for y'all too. > > thanks for pointing this one out. > > -sv > > > > ------------------------------------------------------------------------ > > --- pkgaction.py 26 Aug 2002 04:22:28 -0000 1.27 > +++ pkgaction.py 25 Sep 2002 05:00:09 -0000 1.28 > @@ -138,10 +138,12 @@ > foundit=1 > archlist = archwork.availablearchs(hinevral,name) > bestarch = archwork.bestarch(archlist) > + log(4,"bestarch %s" % bestarch) > for currarch in archlist: > + log(4, "arch = %s" % currarch) > if uplist.count((name,currarch))>0: > #its one of the archs we do and its in the uplist - update it > - log(4,"Updating %s" % (name)) > + log(4, "Updating %s" % (name)) > ((e, v, r, a, l, i), s)=hinevral._get_data(name,currarch) > tsnevral.add((name,e,v,r,a,l,i),'u') > elif uplist.count((name,currarch)) < 1 and nulist.count((name,currarch))>0: > @@ -152,8 +154,8 @@ > tsnevral.add((name,e,v,r,a,l,i),'iu') > elif uplist.count((name,currarch)) < 1 and nulist.count((name,currarch))<1: > #its an arch we do, its not updated and its installed > - errorlog(1,"%s is the latest version" % (name)) > - sys.exit(1) > + #but we keep going b/c we may not be done > + log(5, "nope not %s" % currarch) > if foundit==0: > if rpmnevral.exists(n): > errorlog(1,"%s is installed and the latest version." % (n)) -- __________________________________________________ Troy Dawson dawson@xxxxxxxx (630)840-6468 Fermilab ComputingDivision/OSS CSI Group __________________________________________________
