Hi Lianbo, Please checkout the "Update to gdb-16.2" patchset [1], which I have integrated this patchset into that one. Since the No1 patch is no longer needed after the gdb upgrade, in addition, the No3 patch also made some modification on gdb-10.2.patch, which is removed after the upgrade. All in all, the patchset looks good to me, so we can discuss it there. Thanks, Tao Liu [1]: https://www.mail-archive.com/devel@xxxxxxxxxxxxxxxxxxxxxxxxxxx/msg01347.html On Mon, Jan 27, 2025 at 12:59 AM Tao Liu <ltao@xxxxxxxxxx> wrote: > > Hi Lianbo, > > Thanks for the fix, I will take a look into the series shortly. > > Thanks, > Tao Liu > > On Fri, Jan 24, 2025 at 11:38 PM Lianbo Jiang <lijiang@xxxxxxxxxx> wrote: > > > > The patchset includes three patches: > > [1] [PATCH 1/3] Fix build failure in readline lib > > [2] [PATCH 2/3] tools.c: do not use keywords 'nullptr' as a variable in code > > [3] [PATCH 3/3] Fix build failure on 32bit machine(i686) > > > > Lianbo Jiang (3): > > Fix build failure in readline lib > > tools.c: do not use keywords 'nullptr' as a variable in code > > Fix build failure on 32bit machine(i686) > > > > gdb-10.2.patch | 88 +++++++++++++++++++++++++++++++++++++++++++++++-- > > gdb_interface.c | 4 +-- > > tools.c | 6 ++-- > > 3 files changed, 90 insertions(+), 8 deletions(-) > > > > -- > > 2.47.1 > > -- Crash-utility mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxxxxxx https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/ Contribution Guidelines: https://github.com/crash-utility/crash/wiki