Hi Lianbo, Thanks for your review! > > Can you try to dump the values of the above two variables from > the dump_vm_table() and dump_offset_table()? We can display their values by > help -v and help -o options. > Sure, I will post patch v3 to display the two variables. > > > When initializing the page_page_type, the above "if" check seems to be > redundant. > Okay, it should be removed. > > > Can this page_type_init() be moved to the page_flags_init()? > I don't think so, because the page type is an independent field of struct page which has different usage compared with page flags. What do other reviewers think? Thanks Qiwu -- Crash-utility mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxxxxxx https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/ Contribution Guidelines: https://github.com/crash-utility/crash/wiki
