On Wed, Aug 7, 2024 at 6:47 AM Tao Liu <ltao@xxxxxxxxxx> wrote:
Hi Lianbo,
On Tue, Aug 6, 2024 at 7:06 PM Lianbo Jiang <lijiang@xxxxxxxxxx> wrote:
>
> The commit c3939d2e1930 contains incorrect code that starts with "+",
> for example:
> - !machine_type("S390X") && !machine_type("RISCV64"))
> + !machine_type("S390X") && !machine_type("RISCV64") &&
> ++ !machine_type("LOONGARCH64"))
>
> See the main() in the main.c
> ...
> } else if (STREQ(long_options[option_index].name, "kaslr")) {
> if (!machine_type("X86_64") &&
> !machine_type("ARM64") && !machine_type("X86") &&
> !machine_type("S390X") && !machine_type("RISCV64") &&
> + !machine_type("LOONGARCH64"))
>
> Let's remove it from the main().
Thanks for the patch, the '+' should be removed. For the patch, ack.
Thank you for the review, Tao.
Applied:
Lianbo
Thanks,
Tao Liu
>
> Link: https://lists.crash-utility.osci.io/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxxxxxx/message/LH3IRUA6ZDVFZFLWKW5EWR3DKE6MY25Z/
> Fixes: c3939d2e1930 ("LoongArch64: Add "--kaslr" command line option support")
> Signed-off-by: Lianbo Jiang <lijiang@xxxxxxxxxx>
> ---
> main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/main.c b/main.c
> index 0b6b9273ab06..71bcc1558192 100644
> --- a/main.c
> +++ b/main.c
> @@ -229,7 +229,7 @@ main(int argc, char **argv)
> if (!machine_type("X86_64") &&
> !machine_type("ARM64") && !machine_type("X86") &&
> !machine_type("S390X") && !machine_type("RISCV64") &&
> -+ !machine_type("LOONGARCH64"))
> + !machine_type("LOONGARCH64"))
> error(INFO, "--kaslr not valid "
> "with this machine type.\n");
> else if (STREQ(optarg, "auto"))
> --
> 2.45.1
> --
> Crash-utility mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxxxxxx
> To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxxxxxx
> https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/
> Contribution Guidelines: https://github.com/crash-utility/crash/wiki
-- Crash-utility mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxxxxxx https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/ Contribution Guidelines: https://github.com/crash-utility/crash/wiki
