On Fri, Jun 28, 2024 at 3:34 PM lijiang <lijiang@xxxxxxxxxx> wrote: > > On Fri, May 31, 2024 at 5:38 PM <devel-request@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: >> >> Date: Fri, 31 May 2024 17:19:37 +0800 >> From: Tao Liu <ltao@xxxxxxxxxx> >> Subject: [PATCH v4 14/16] x86_64: fix gdb bt for >> vmware dumps >> To: devel@xxxxxxxxxxxxxxxxxxxxxxxxxxx >> Cc: Alexey Makhalov <alexey.makhalov@xxxxxxxxxxxx>, Mahesh J >> Salgaonkar <mahesh@xxxxxxxxxxxxx>, "Naveen N . Rao" >> <naveen.n.rao@xxxxxxxxxxxxxxxxxx>, Lianbo Jiang <lijiang@xxxxxxxxxx> >> Message-ID: <20240531091939.97828-15-ltao@xxxxxxxxxx> >> Content-Type: text/plain; charset=UTF-8 >> >> From: Alexey Makhalov <alexey.makhalov@xxxxxxxxxxxx> >> >> vmware_vmss_get_cpu_reg() whould be called only for active tasks >> to get their registers from corresponding CPUs. >> Otherwise, the standard path of fetching pt_regs from the memory >> (inactive_task_frame) should be used. >> >> Cc: Sourabh Jain <sourabhjain@xxxxxxxxxxxxx> >> Cc: Hari Bathini <hbathini@xxxxxxxxxxxxx> >> Cc: Mahesh J Salgaonkar <mahesh@xxxxxxxxxxxxx> >> Cc: Naveen N. Rao <naveen.n.rao@xxxxxxxxxxxxxxxxxx> >> Cc: Lianbo Jiang <lijiang@xxxxxxxxxx> >> Cc: HAGIO KAZUHITO(萩尾 一仁) <k-hagio-ab@xxxxxxx> >> Cc: Tao Liu <ltao@xxxxxxxxxx> >> Cc: Alexey Makhalov <alexey.makhalov@xxxxxxxxxxxx> >> Signed-off-by: Alexey Makhalov <alexey.makhalov@xxxxxxxxxxxx> >> --- >> x86_64.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/x86_64.c b/x86_64.c >> index 47c215f..617a4ab 100644 >> --- a/x86_64.c >> +++ b/x86_64.c >> @@ -9232,7 +9232,10 @@ x86_64_get_current_task_reg(int regno, const char *name, >> if (!tc) >> return FALSE; >> >> - if (VMSS_DUMPFILE()) >> + /* >> + * Task is active, grab CPU's registers >> + */ >> + if (is_task_active(tc->task) && VMSS_DUMPFILE()) >> return vmware_vmss_get_cpu_reg(tc->processor, regno, name, size, value); >> > > Can you try to fold this change into the [PATCH 09/16]? And add the current descriptions in the patch log. > OK, will merge it. Thanks, Tao Liu > Thanks > Lianbo > >> BZERO(&bt_setup, sizeof(struct bt_info)); >> -- >> 2.40.1 -- Crash-utility mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxxxxxx https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/ Contribution Guidelines: https://github.com/crash-utility/crash/wiki
