Hi Tao & Kazu,
On 21/03/24 14:30, Tao Liu wrote:
Thanks for the comments. Yes, I guess if we all agree that 1 thread gdb is better, then I and Aditya can work together to clean up the code, e.g. rearrange the powerpc series and mine. I agree the code which gets added and then removed should be cleaned up in later patchsets.
Let's rebase our patch series then.
As of now it's a lot of dependent patches here and there. I think
maybe your "Leave only one thread for gdb" commit should go first.
It simplifies the implementation.
And, with it being 1 gdb thread, and all of us using 'CURRENT_CONTEXT', I guess it makes sense to rename 'machdep->get_cpu_reg' to 'machdep->get_current_reg'.
Any comments ?
I think you're going to do this later though, just in case.Thanks, Tao Liu[1] https://github.com/crash-utility/crash/wiki#writing-patches Thanks, Kazu-- Crash-utility mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxxxxxx https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/ Contribution Guidelines: https://github.com/crash-utility/crash/wiki
-- Crash-utility mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxxxxxx https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/ Contribution Guidelines: https://github.com/crash-utility/crash/wiki
