[Crash-utility] Re: [PATCH v2] help.c: Remove kmem -l help messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2023/12/15 11:44, Li Zhijian wrote:
> -l option has existed when crash git project initialization, but its
> help message was not accurate(extra arguments a|i|ic|id was missing).
> 
> In addition, these symbols required by -l option was for the very *old old*
> kernels, at least >= 2.6 don't include them. And it looks like this option
> has not been fixed for a long time.
> 
> Instead of document this option, hide it from help messages.
> 
> Signed-off-by: Li Zhijian <lizhijian@xxxxxxxxxxx>
Thanks,

Acked-by: Kazuhito Hagio <k-hagio-ab@xxxxxxx>

> ---
>   help.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/help.c b/help.c
> index cc7ab20e343e..d80e843703c1 100644
> --- a/help.c
> +++ b/help.c
> @@ -6888,8 +6888,6 @@ char *help_kmem[] = {
>   "            members of the associated page struct are displayed.",
>   "   address  when used with -c, the address must be a page pointer address;",
>   "            the page_hash_table entry containing the page is displayed.",
> -"   address  when used with -l, the address must be a page pointer address;",
> -"            the page address is displayed if it is contained with the list.",
>   "   address  when used with -v, the address can be a mapped kernel virtual",
>   "            address or physical address; the mapped region containing the",
>   "            address is displayed.\n",
--
Crash-utility mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxxxxxx
https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/
Contribution Guidelines: https://github.com/crash-utility/crash/wiki




[Index of Archives]     [Fedora Development]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]

 

Powered by Linux