On 14/12/2023 10:59, HAGIO KAZUHITO(萩尾 一仁) wrote:
> On 2023/12/01 16:40, Li Zhijian wrote:
>> Per the soucde code, '-l' requires extra arguments but it's missing in
>> documentation.
>>
>> Signed-off-by: Li Zhijian <lizhijian@xxxxxxxxxxx>
>> ---
>> help.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/help.c b/help.c
>> index cc7ab20e343e..568b8f3b151a 100644
>> --- a/help.c
>> +++ b/help.c
>> @@ -6888,8 +6888,9 @@ char *help_kmem[] = {
>> " members of the associated page struct are displayed.",
>> " address when used with -c, the address must be a page pointer address;",
>> " the page_hash_table entry containing the page is displayed.",
>> -" address when used with -l, the address must be a page pointer address;",
>> +" address when used with [-l a|i|ic|id], the address must be a page pointer address;",
>> " the page address is displayed if it is contained with the list.",
>> +" where a:active_list, i:inactive_list, ic:inactive_clean_list, id:inactive_dirty_list",
>> " address when used with -v, the address can be a mapped kernel virtual",
>> " address or physical address; the mapped region containing the",
>> " address is displayed.\n",
>
> Thanks for the patch, but what kernel versions does this option support?
> The oldest vmcore I have is 2.6.9 (RHEL4), even it is not supported:
>
Yeah, someone said the kernel <=2.4 had such symbols, but i didn't find them in the kernel source(tested 2.3.30, 2.3.40)
> crash-x86> kmem -l a c103af40
> kmem: active_list does not exist in this kernel
>
> It looks like this option has not been fixed for a long time, so I think
> there is no demand so far. I would not like to make it go public for now.
>
Agreed
> So if we do something, how about removing the two lines..?
it sounds good to me, i will remove it in V2.
>
> Thanks,
> Kazu
--
Crash-utility mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxxxxxx
https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/
Contribution Guidelines: https://github.com/crash-utility/crash/wiki
