[Crash-utility] Re: Patches for zram, swap cache fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > Hi
> > Sharing 3 changes for zram regarding swap cache handling. Please have a look.
> >
> > Subject: [PATCH 1/3] zram, swap cache missing page tree offset
> > Subject: [PATCH 2/3] zram, swap cache entries are pointer to struct page
> > Subject: [PATCH 3/3] zram, exclude shadow entries from swap cache lookup
> 
> Thank you for the patches.
> 
>  > /* this already exists in maple_tree.h add to defs.h ? */
> 
> Is it ok to add '#include maple_tree.h' ?

Yes, that should work perfectly for 'xa_is_value'.

> 
> and the warning below is emitted, this can be fixed when merging.
> 
> diskdump.c: In function 'lookup_swap_cache':
> diskdump.c:2890:29: warning: unused variable 'page' [-Wunused-variable]
>    ulong swp_type, swp_space, page;
>                               ^~~~

Sorry, I missed that one. Thanks for reviewing.

Johan
--
Crash-utility mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxxxxxx
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
Contribution Guidelines: https://github.com/crash-utility/crash/wiki




[Index of Archives]     [Fedora Development]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]

 

Powered by Linux