[Crash-utility] Re: [PATCH] Fix printing incorrect panic string issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2023/11/13 20:09, Lianbo Jiang wrote:
> Since the panic_on_oops is disabled, when getting a BUG hit in the code,
> the system continues and does not panic. However, a short time later, a
> hard lockup is hit and the system does panic. Even though the system
> panicked at hard lockup, the panic string is still the first BUG hit.
> For example:
> 
> Without the patch:
>    crash> sys|grep PANIC
>           PANIC: "BUG: unable to handle kernel paging request at ffffab835d7f9d50"
> 
> With the patch:
>    crash> sys|grep PANIC
>           PANIC: "Kernel panic - not syncing: Hard LOCKUP"
> 
> Let's search for the panic string based on the severity of the panic
> event, and also refactore the get_panicmsg() a little bit to improve
> readability.
> 
> Reported-by: John Pittman <jpittman@xxxxxxxxxx>
> Signed-off-by: Lianbo Jiang <lijiang@xxxxxxxxxx>

Thanks for the fix and cleanup.
Looks good, applied with some indent tweaks.

https://github.com/crash-utility/crash/commit/262b1c71b485632ee3b56f5742ee915a17e70c41

Thanks,
Kazu
--
Crash-utility mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxxxxxx
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
Contribution Guidelines: https://github.com/crash-utility/crash/wiki




[Index of Archives]     [Fedora Development]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]

 

Powered by Linux