[Crash-utility] Re: [PATCH v3] add "files -n" command for an inode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




在 2023/11/6 13:16, HAGIO KAZUHITO(萩尾 一仁) 写道:
On 2023/11/06 14:04, HAGIO KAZUHITO(萩尾 一仁) wrote:
On 2023/11/03 18:45, Shijie Huang wrote:

+summary_inode_page(ulong page)
+{
+       int node;
+
+       if (!is_page_ptr(page, NULL))
+               error(FATAL, "Invalid inode page(0x%lx)\n", page);
I don't remember the detail of xarray, but my cacheutils extension
module also checks this without any error, in its callback function [1].
So how about implementing like this?
in the first place, dump_inode_page() for "files -p" also checks this
first without any error.  I think we can follow this.

https://github.com/crash-utility/crash/blob/master/memory.c#L6891

okay. no problem.


BTW: If we have time, we may debug the xarray issue.


Thanks

Huang Shijie
--
Crash-utility mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxxxxxx
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
Contribution Guidelines: https://github.com/crash-utility/crash/wiki




[Index of Archives]     [Fedora Development]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]

 

Powered by Linux