On 2023/10/24 16:12, Huang Shijie wrote:
> In the NUMA machine, it is useful to know the memory distribution of
> an inode page cache:
> How many pages in the node 0?
> How many pages in the node 1?
>
> Add "files -n" command to get the memory distribution information:
> 1.) Add new argument for dump_inode_page_cache_info()
> 2.) make page_to_nid() a global function.
> 3.) Add summary_inode_page() to check each page's node
> information.
> 4.) Use print_inode_summary_info() to print the
> memory distribution information of an inode.
>
> Tested with the /proc/kcore.
>
> Signed-off-by: Huang Shijie <shijie@xxxxxxxxxxxxxxxxxxxxxx>
> ---
> v1 --> v2:
> 1.) rebased the code on the latest tree.
> 2.) added return value for summary_inode_page().
> 3.) Changed the output format.
> 4.) Changed the ulong.
> 5.) others.
Thank you for the update.
> @@ -7974,6 +7976,14 @@ char *help_files[] = {
> " ca1ddde0 2eeef000 f59b91ac 3 2 82c referenced,uptodate,lru,private",
> " ca36b300 3b598000 f59b91ac 4 2 82c referenced,uptodate,lru,private",
> " ca202680 30134000 f59b91ac 5 2 82c referenced,uptodate,lru,private",
> +" ",
I will add here a description like
" For the inode at address ffff07ff8c6f97f8, display the NUMA node",
" distribution of its pages that are in the page cache:",
and some spacing tweaks, when merging. Also, the patch tested ok.
crash> files -n ffff976500fc2e48
INODE NRPAGES
ffff976500fc2e48 50943
NODE PAGES
0 50927
1 16
Acked-by: Kazuhito Hagio <k-hagio-ab@xxxxxxx>
Thanks,
Kazu
--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/crash-utility
Contribution Guidelines: https://github.com/crash-utility/crash/wiki
