Re: [PATCH] deduplicate kernel_version open-coded parser

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2023/08/17 18:18, lijiang wrote:
> On Tue, Aug 15, 2023 at 10:41 AM <crash-utility-request@xxxxxxxxxx> wrote:
> 
>> Date: Mon, 14 Aug 2023 09:41:12 -0400
>> From: Rafael Aquini <aquini@xxxxxxxxxx>
>> To: crash-utility@xxxxxxxxxx
>> Cc: raquini@xxxxxxxxxx
>> Subject:  [PATCH] deduplicate kernel_version open-coded
>>          parser
>> Message-ID: <20230814134112.232436-1-aquini@xxxxxxxxxx>
>>
>> The code that parses kernel version from OSRELEASE/UTSRELEASE strings
>> and populates the global kernel table is duplicated across the codebase
>> for no good reason. This commit consolidates all the duplicated parsing
>> code into a single method to remove the unnecessary duplicated code.
>>
>>
> Thank you for the patch, Rafael.
> 
> And this looks good to me, so:  Ack.

Applied.
https://github.com/crash-utility/crash/commit/f774fe0f59b45596e5165eb008845b3534f650d0

Thanks,
Kazu
--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/crash-utility
Contribution Guidelines: https://github.com/crash-utility/crash/wiki




[Index of Archives]     [Fedora Development]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]

 

Powered by Linux