Re: [PATCH] deduplicate kernel_version open-coded parser

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 16, 2023 at 02:16:51AM +0000, HAGIO KAZUHITO(萩尾 一仁) wrote:
> On 2023/08/14 22:42, Rafael Aquini wrote:
> > On Mon, Aug 14, 2023 at 09:41:12AM -0400, Rafael Aquini wrote:
> >> The code that parses kernel version from OSRELEASE/UTSRELEASE strings
> >> and populates the global kernel table is duplicated across the codebase
> >> for no good reason. This commit consolidates all the duplicated parsing
> >> code into a single method to remove the unnecessary duplicated code.
> >>
> > 
> > this changeset is also at https://github.com/crash-utility/crash/pull/151
> >   
> >> Signed-off-by: Rafael Aquini <aquini@xxxxxxxxxx>
> 
> Good to see you again :)

Kazu,

good to see you too!

 
> Thank you for the clean-up, looks good to me.
> 
> Acked-by: Kazuhito Hagio <k-hagio-ab@xxxxxxx>
> 

Thanks!
-- Rafael

--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/crash-utility
Contribution Guidelines: https://github.com/crash-utility/crash/wiki




[Index of Archives]     [Fedora Development]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]

 

Powered by Linux