On 2023/06/23 11:11, lijiang wrote:
> On Thu, Jun 22, 2023 at 3:09 PM HAGIO KAZUHITO(萩尾 一仁) <k-hagio-ab@xxxxxxx>
> wrote:
>
>> Support module memory layout change on Linux 6.4 by kernel commit
>> ac3b43283923 ("module: replace module_layout with module_memory") [1].
>> Without the patch, crash cannot even start a session with an error
>> message like this:
>>
>> crash: invalid structure member offset: module_core_size
>> FILE: kernel.c LINE: 3787 FUNCTION: module_init()
>>
>> [1]
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ac3b43283923
>>
>> Signed-off-by: Kazuhito Hagio <k-hagio-ab@xxxxxxx>
>> ---
>> v1 -> v2
>> - Made several functions in symbol.c static
>> - Fixed a compilation warning on gdb-10.2/gdb/symtab.c
>> - Fixed a compilation error with an old gcc like RHEL7
>> - Fixed a v1 bug, "sym" doesn't show multiple symbols with the same name:
>> crash> sym cleanup_module
>> ffffffffc07fc8c0 (T) cleanup_module [dm_mod]
>> crash>
>>
>> v1:
>> https://listman.redhat.com/archives/crash-utility/2023-June/010806.html
>> RFC:
>> https://listman.redhat.com/archives/crash-utility/2023-May/010647.html
>>
>>
> Thank you for the great job, Kazu.
>
> For the v2: Ack.
Thank you for your great review effort and nice comments, applied.
https://github.com/crash-utility/crash/commit/7750e61fdb2a083f26156a5338aa2ebe26447f3f
Thanks,
Kazu
--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/crash-utility
Contribution Guidelines: https://github.com/crash-utility/crash/wiki
