On Fri, Jun 2, 2023 at 10:42 AM HAGIO KAZUHITO(萩尾 一仁) <k-hagio-ab@xxxxxxx> wrote:
On 2023/06/01 18:59, lijiang wrote:
> On Thu, Jun 1, 2023 at 4:18 PM HAGIO KAZUHITO(萩尾 一仁) <k-hagio-ab@xxxxxxx>
> wrote:
>
>>>
>>> If this is not used, can we set it to an invalid value such as -1(ulong->
>>> 0xffffffff)? Otherwise we can still see a valid value by "help -s"
>> command.
>>
>> Agree to set an invalid value, but I would like 0. -1 hits this:
>>
>>
> Fine to me, but I see the following code in crash-utility:
> ...
> if (!lm->mod_etext_guess)
> find_mod_etext(lm);
> ...
>
> If they have no conflicts, that should be good.
These are in store_module_symbols_v{1,2} functions, not called.
When MODULE_MEMORY(), only one use of lm->mod_etext_guess is in "help -s".
Sounds good, I have no other issues. Thank you for the explanation, Kazu.
Thanks.
Lianbo
-- Crash-utility mailing list Crash-utility@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/crash-utility Contribution Guidelines: https://github.com/crash-utility/crash/wiki
