On 2023/05/18 16:45, lijiang wrote:
> On Thu, May 18, 2023 at 12:28 PM HAGIO KAZUHITO(萩尾 一仁) <k-hagio-ab@xxxxxxx>
> wrote:
>
>> Kernel commit 869176a09606 ("mm/vmalloc.c: add flags to mark vm_map_ram
>> area"), which is contained in Linux 6.3 and later, added "flags" member
>> to struct vmap_area. This was the revival of the "flags" member as
>> kernel commit 688fcbfc06e4 had eliminated it before.
>>
>> As a result, crash started to use the old procedure using the member and
>> displays no vmalloc'd regions, because it does not have the same flag
>> value as the old one.
>>
>> crash> kmem -v
>> VMAP_AREA VM_STRUCT ADDRESS RANGE
>> SIZE
>> crash>
>>
>> To fix this, also check if vmap_area.purge_list exists, which was
>> introduced with the flags and removed later, to determine that the flags
>> member is the old one.
>>
>> Related vmap_area history:
>> v2.6.28 db64fe02258f introduced vmap_area with flags and purge_list
>> v5.4 688fcbfc06e4 removed flags
>> v5.11 96e2db456135 removed purge_list
>> v6.3 869176a09606 added flags again
>>
>
> Thank you for the fix, Kazu.
>
> It looks good to me. So: Ack.
Thank you for the review, applied.
https://github.com/crash-utility/crash/commit/342cf340ed0386880fe2a3115d6bef32eabb511b
Thanks,
Kazu
--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/crash-utility
Contribution Guidelines: https://github.com/crash-utility/crash/wiki
