On 2023/05/16 12:52, lijiang wrote:
> Thank you for the fix, Kazu.
> On Tue, May 16, 2023 at 8:27 AM HAGIO KAZUHITO(萩尾 一仁) <k-hagio-ab@xxxxxxx>
> wrote:
>
>> Kernel commit 2df418cf4b72 ("driver core: class: remove subsystem
>> private pointer from struct class"), which is contained in Linux 6.4 and
>> later kernels, removed the class.p member for struct subsys_private. As
>> a result, the "dev -d|-D" options fail with the following error.
>>
>> dev: invalid structure member offset: class_p
>> FILE: dev.c LINE: 4689 FUNCTION: init_iter()
>>
>> Search the class_kset list for the subsys_private of block class to fix
>> this.
>>
>> As a preparation, introduce get_subsys_private() function, which is
>> abstracted from the same search procedure in init_memory_block().
>>
>>
> Looks good to me. So: Ack
Thank you, applied.
https://github.com/crash-utility/crash/commit/58c1816521c2e6bece3d69256b1866c9df8d93aa
Kazu
--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/crash-utility
Contribution Guidelines: https://github.com/crash-utility/crash/wiki
