Hi, Juergen
Thank you for the patchset.The xen-related code in crash-utility has not been updated for a long time. That somewhat relies on xen developers.
On Mon, Mar 13, 2023 at 9:07 PM <crash-utility-request@xxxxxxxxxx> wrote:
Date: Mon, 13 Mar 2023 14:01:10 +0100
From: Juergen Gross <jgross@xxxxxxxx>
To: crash-utility@xxxxxxxxxx
Subject: [PATCH 1/3] xen: fix stacksize
Message-ID: <20230313130112.15353-2-jgross@xxxxxxxx>
Content-Type: text/plain; charset="US-ASCII"; x-default=true
The size of the percpu stack of Xen on x86_64 is 8 pages, not 2.
While not really critical in its current usage, it should be corrected
nevertheless.
Could you please add the related xen commit(if any) to the patch log? That can help us quickly review patches, and easily retrace it in the future.
Thanks.
Lianbo
Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
---
Makefile | 14 +++++++-------
x86_64.c | 2 +-
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/x86_64.c b/x86_64.c
index 8e3eb89..5019c69 100644
--- a/x86_64.c
+++ b/x86_64.c
@@ -8113,7 +8113,7 @@ x86_64_init_hyper(int when)
machdep->pageshift = ffs(machdep->pagesize) - 1;
machdep->pageoffset = machdep->pagesize - 1;
machdep->pagemask = ~((ulonglong)machdep->pageoffset);
- machdep->stacksize = machdep->pagesize * 2;
+ machdep->stacksize = machdep->pagesize * 8;
if ((machdep->pgd = (char *)malloc(PAGESIZE())) == NULL)
error(FATAL, "cannot malloc pgd space.");
if ((machdep->pud = (char *)malloc(PAGESIZE())) == NULL)
--
2.35.3
-- Crash-utility mailing list Crash-utility@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/crash-utility Contribution Guidelines: https://github.com/crash-utility/crash/wiki
