Re: [PATCH 1/3] xen: fix stacksize

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 13.03.23 14:01, Juergen Gross wrote:
The size of the percpu stack of Xen on x86_64 is 8 pages, not 2.

While not really critical in its current usage, it should be corrected
nevertheless.

Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
---
  Makefile | 14 +++++++-------
  x86_64.c |  2 +-
  2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/Makefile b/Makefile
index a94a243..c4fdbe7 100644
--- a/Makefile
+++ b/Makefile
@@ -24,7 +24,7 @@ PROGRAM=crash
  # Supported targets: X86 ALPHA PPC IA64 PPC64 SPARC64
  # TARGET and GDB_CONF_FLAGS will be configured automatically by configure
  #
-TARGET=
+TARGET=X86_64
  GDB_CONF_FLAGS=
ARCH := $(shell uname -m | sed -e s/i.86/i386/ -e s/sun4u/sparc64/ -e s/arm.*/arm/ -e s/sa110/arm/)
@@ -35,10 +35,10 @@ endif
  #
  # GDB, GDB_FILES, GDB_OFILES and GDB_PATCH_FILES will be configured automatically by configure
  #
-GDB=
-GDB_FILES=
-GDB_OFILES=
-GDB_PATCH_FILES=
+GDB=gdb-10.2
+GDB_FILES=${GDB_10.2_FILES}
+GDB_OFILES=${GDB_10.2_OFILES}
+GDB_PATCH_FILES=gdb-10.2.patch
#
  # Default installation directory
@@ -190,7 +190,7 @@ GDB_10.2_OFILES=${GDB}/gdb/symtab.o crash_target.o
  #
  # GDB_FLAGS is passed up from the gdb Makefile.
  #
-GDB_FLAGS=
+GDB_FLAGS=-DGDB_10_2
#
  # WARNING_OPTIONS and WARNING_ERROR are both applied on a per-file basis.
@@ -207,7 +207,7 @@ TARGET_CFLAGS=
CRASH_CFLAGS=-g -D${TARGET} ${TARGET_CFLAGS} ${GDB_FLAGS} ${CFLAGS} -GPL_FILES=
+GPL_FILES=COPYING3
  TAR_FILES=${SOURCE_FILES} Makefile ${GPL_FILES} README .rh_rpm_package crash.8 \
  	${EXTENSION_SOURCE_FILES} ${MEMORY_DRIVER_FILES}
  CSCOPE_FILES=${SOURCE_FILES}

Oh, sorry, obviously "make" is modifying the Makefile, which shouldn't be
part of this patch.

Please ignore the Makefile modifications when reviewing. I won't resend for
now, as it seems to be more appropriate to wait for some more feedback.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature

--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/crash-utility
Contribution Guidelines: https://github.com/crash-utility/crash/wiki

[Index of Archives]     [Fedora Development]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]

 

Powered by Linux