Re: [PATCH] Fix for "bt" command incorrectly printing eframe stack with a bogus warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 16, 2023 at 8:48 AM <crash-utility-request@xxxxxxxxxx> wrote:
Hello,

For upstream crash, and this is more a general thought,  what about ordering tests with most recent kernel changes being tested first:


Good question.

For example, in Lianbo's case, instead of:
-                   (STREQ(sp->name, "call_softirq") || STREQ(sp->name, "do_softirq_own_stack")))
What about reversing the order of the tests:
+                   (STREQ(sp->name, " do_softirq_own_stack") || STREQ(sp->name, " call_softirq")))

As distros tend to move fast forward, ordering tests with most recent kernel changes being tested first would make sense.

 
It's true. If this happens during the bootup and there are hundreds of symbols, it will benefit more. Otherwise the cumulative effect is small, the
impact is almost negligible.

But anyway, this still makes sense. Thank you for the discussion, Georges. 

Lianbo
--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/crash-utility
Contribution Guidelines: https://github.com/crash-utility/crash/wiki

[Index of Archives]     [Fedora Development]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]

 

Powered by Linux