On Wed, Dec 07, 2022 at 02:01:56AM +0000, HAGIO KAZUHITO(萩尾 一仁) wrote:
> Thanks for the patch.
>
> On 2022/12/06 19:00, Pavankumar Kondeti wrote:
> > After the commit 0d9b1ffefabe ("arm64: mm: make vabits_actual
> > a build time constant if possible") introduced in v5.19
> > Linux kernel, the crash will not find vabits_actual symbol.
>
> "if VA_BITS <= 48" ?
>
Thats right.
> > Add a fallback option to initialize VA_BITS based on the
> > user supplied machdep options.
> >
> > Tested ramdumps loading in both 6.0 and 5.15 kernels.
>
> What if kernels < 5.4? For such old kernels without vabits_actual
> introduced, probably we should not set VA_BITS_ACTUAL..
>
>
ok, so what if the user passes -m vabits_actual=X on an older kernel dumps.
Earlier we ignore it, but now we end up using it. should I add a kernel
version check in fallback() routine?
Thanks,
Pavan
--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/crash-utility
Contribution Guidelines: https://github.com/crash-utility/crash/wiki
