Re: [PATCH V4 1/9] Add RISCV64 framework code support

[Xianting Tian <xianting.tian@xxxxxxxxxxxxxxxxx>]

在 2022/11/3 下午1:32, lijiang 写道:
> On Fri, Oct 21, 2022 at 10:57 AM HAGIO KAZUHITO(萩尾　一仁)
> <k-hagio-ab@xxxxxxx> wrote:
> > On 2022/10/21 11:42, Xianting Tian wrote:
> > > 在 2022/10/21 上午10:17, HAGIO KAZUHITO(萩尾 一仁) 写道:
> > > > On 2022/10/20 10:50, Xianting Tian wrote:
> > > >
> > > > > diff --git a/README b/README
> > > > > index 5abbce1..d589e72 100644
> > > > > --- a/README
> > > > > +++ b/README
> > > > > @@ -37,7 +37,7 @@
> > > > >       These are the current prerequisites:
> > > > >       o  At this point, x86, ia64, x86_64, ppc64, ppc, arm, arm64, alpha, mips,
> > > > > -     mips64, s390 and s390x-based kernels are supported.  Other architectures
> > > > > +     mips64, riscv64, s390 and s390x-based kernels are supported.  Other architectures
> > > > >          may be addressed in the future.
> > > > Sentences in the README are wrapped within 80 characters, I will change
> > > thanks,
> > >
> > > Do you need me to send V5 patch set to fix this?
> > No, I will amend these when applying.
> On the kernel side, some relevant kernel patches got ack,  it seems
> they won't  change anymore.
>
> And the V4 looks good to me, so: Ack.
Thanks,  Linux kenrel RISC-V maintainer still don't apply the kernel 
patch,  let's wait.
> Thanks.
> Lianbo
>
> > Thanks,
> > Kazu
> >
> > > > this to:
> > > >
> > > > +     mips64, riscv64, s390 and s390x-based kernels are supported.  Other
> > > > +     architectures may be addressed in the future.
> > > >
> > > > >       o  One size fits all -- the utility can be run on any Linux kernel version
> > > > > @@ -98,6 +98,8 @@
> > > > >          arm64 dumpfiles may be built by typing "make target=ARM64".
> > > > >       o  On an x86_64 host, an x86_64 binary that can be used to analyze
> > > > >          ppc64le dumpfiles may be built by typing "make target=PPC64".
> > > > > +  o  On an x86_64 host, an x86_64 binary that can be used to analyze
> > > > > +     riscv64 dumpfiles may be built by typing "make target=RISCV64".
> > > > >       Traditionally when vmcores are compressed via the makedumpfile(8) facility
> > > > >       the libz compression library is used, and by default the crash utility
> > > > > diff --git a/help.c b/help.c
> > > > > index 99214c1..253c71b 100644
> > > > > --- a/help.c
> > > > > +++ b/help.c
> > > > > @@ -9512,7 +9512,7 @@ char *README[] = {
> > > > >     "  These are the current prerequisites: ",
> > > > >     "",
> > > > >     "  o  At this point, x86, ia64, x86_64, ppc64, ppc, arm, arm64, alpha, mips,",
> > > > > -"     mips64, s390 and s390x-based kernels are supported.  Other architectures",
> > > > > +"     mips64, riscv64, s390 and s390x-based kernels are supported.  Other architectures",
> > > > >     "     may be addressed in the future.",
> > > > >     "",
> > > > >     "  o  One size fits all -- the utility can be run on any Linux kernel version",
> > > > Same as above.
> > > >
> > > > And help.c lacks this part, will add:
> > > >
> > > > @@ -9572,6 +9572,8 @@ README_ENTER_DIRECTORY,
> > > >     "     arm64 dumpfiles may be built by typing \"make target=ARM64\".",
> > > >     "  o  On an x86_64 host, an x86_64 binary that can be used to analyze",
> > > >     "     ppc64le dumpfiles may be built by typing \"make target=PPC64\".",
> > > > +"  o  On an x86_64 host, an x86_64 binary that can be used to analyze",
> > > > +"     riscv64 dumpfiles may be built by typing \"make target=RISCV64\".",
> > > >     "",
> > > >     "  Traditionally when vmcores are compressed via the makedumpfile(8) facility",
> > > >     "  the libz compression library is used, and by default the crash utility",
> > > >
> > > >
> > > > With these, the v4 crash patch set looks good to me.
> > > >
> > > > Acked-by: Kazuhito Hagio <k-hagio-ab@xxxxxxx>
> > > >
> > > > Thanks,
> > > > Kazu

--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/crash-utility
Contribution Guidelines: https://github.com/crash-utility/crash/wiki