On Mon, Oct 10, 2022 at 9:23 AM Kazuhito Hagio <kazuhito.hagio@xxxxxxxxx> wrote:
On Sat, Oct 8, 2022 at 12:27 PM lijiang <lijiang@xxxxxxxxxx> wrote:
>> --- a/ppc64.c
>> +++ b/ppc64.c
>> @@ -1947,7 +1947,7 @@ ppc64_in_emergency_stack(int cpu, ulong addr, bool verbose)
>> if (cpu < 0 || cpu >= kt->cpus)
>> return NONE_STACK;
>>
>> - if (ms->emergency_sp) {
>> + if (ms->emergency_sp && ms->emergency_sp[cpu]) {
>
>
> Is it better to use the IS_KVADDR(ms->emergency_sp[cpu]) ? For example:
>
> + if (ms->emergency_sp && IS_KVADDR(ms->emergency_sp[cpu]) ) {
Yes, looks better. Please go ahead with this.
Thanks. Applied.
Lianbo
-- Crash-utility mailing list Crash-utility@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/crash-utility Contribution Guidelines: https://github.com/crash-utility/crash/wiki
