Re: [PATCH] arm64: use TCR_EL1_T1SZ to get the correct info if vabits_actual is missing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2022/08/26 12:46, lijiang wrote:
> Thank you for the fix, Shijie.
> On Wed, Aug 24, 2022 at 2:26 PM HAGIO KAZUHITO(萩尾 一仁) <k-hagio-ab@xxxxxxx>
> wrote:
> 
>> On 2022/08/22 18:29, Huang Shijie wrote:
>>> After kernel patch:
>>>      "0d9b1ffefabe arm64: mm: make vabits_actual a build time constant if
>> possible"
>>> the "vabits_actual" is not compiled to kernel symbols when "VA_BITS > 48"
>>> is false.
>>>
>>> So the crash will not find the "vabits_actual" symbol, and it will
>>> fail in the end.
>>>
> 
> 
> Can you help add the actual failure information to the patch log? Kazu.
> 
> # ./crash -s
> WARNING: VA_BITS: calculated: 46  vmcoreinfo: 48
> crash: invalid kernel virtual address: ffff88177ffff000  type: "pud page"
> 
> This change looks good and the test is ok. So:  Ack.

Thanks, applied.
https://github.com/crash-utility/crash/commit/f02c8e87fccb1a92fbc025883bc69b6467a4e6c8

Thanks,
Kazu
--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/crash-utility
Contribution Guidelines: https://github.com/crash-utility/crash/wiki




[Index of Archives]     [Fedora Development]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]

 

Powered by Linux