On 2022/07/04 17:40, Qianli Zhao wrote: > From: Qianli Zhao <qianli.zhao@xxxxxxxxxx> > > Setting st->_stext_vmlinux to UNINITIALIZED to search for "_stext" > from the vmlinux. In the scenario where kaslr is disabled and > without vmcore file, will get the wrong MODULES/VMALLOC ranges, Thanks for the update, probably s/vmcore file/vmcoreinfo/ is better, but we will fix it. Acked-by: Kazuhito Hagio <k-hagio-ab@xxxxxxx> Lianbo, I think we can merge this first for the ramdump issue, but is it better to look into the issue you found before merging this? Thanks, Kazu > cause parsing raw dumpfile failure > > Signed-off-by: Qianli Zhao <qianli.zhao@xxxxxxxxxx> > --- > v2: Update patch log and add some comment in code. > > --- > arm64.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arm64.c b/arm64.c > index 0f615cf..5d306cd 100644 > --- a/arm64.c > +++ b/arm64.c > @@ -149,6 +149,15 @@ arm64_init(int when) > > ms = machdep->machspec; > > + /* > + * The st->_stext_vmlinux is needed in arm64_init(PRE_GDB) when a > + * dumpfile does not have vmcoreinfo and we use -m vabits_actual > + * option, e.g. a raw RAM dumpfile. > + * > + */ > + if (ms->VA_BITS_ACTUAL) > + st->_stext_vmlinux = UNINITIALIZED; > + > if (!ms->kimage_voffset && STREQ(pc->live_memsrc, "/dev/crash")) > ioctl(pc->mfd, DEV_CRASH_ARCH_DATA, &ms->kimage_voffset); > -- Crash-utility mailing list Crash-utility@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/crash-utility Contribution Guidelines: https://github.com/crash-utility/crash/wiki
