On 2022/06/10 13:58, lijiang wrote: > @@ -130,7 +132,10 @@ static unsigned int sbitmap_weight(const struct sbitmap_context *sc) > > static unsigned int sbitmap_cleared(const struct sbitmap_context *sc) > { > - return __sbitmap_weight(sc, false); > + if (VALID_MEMBER(sbitmap_word_cleared)) /* 5.0 and later */ > + return __sbitmap_weight(sc, false); > + else > > > The above "else" can be removed, and the result is the same. > > Other changes look good to me, for these three patches: > Acked-by: Lianbo Jiang <lijiang@xxxxxxxxxx <mailto:lijiang@xxxxxxxxxx>> Thanks for the quick review, applied them with the removal. Thanks, Kazu -- Crash-utility mailing list Crash-utility@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/crash-utility Contribution Guidelines: https://github.com/crash-utility/crash/wiki