On 2022/05/24 18:11, lijiang wrote: > Thank you for the review, Kazu. > > On Tue, May 24, 2022 at 4:39 PM HAGIO KAZUHITO(萩尾 一仁) <k-hagio-ab@xxxxxxx <mailto:k-hagio-ab@xxxxxxx>> wrote: > > Hi Lianbo, > > On 2022/05/23 19:04, Lianbo Jiang wrote: > > The sbitmapq command will fail due to the following kernel commit: > > > > [1] commit <c548e62bcf6a> ("scsi: sbitmap: Move allocation hint > > into sbitmap") > > [2] commit <efe1f3a1d583> ("scsi: sbitmap: Maintain allocation > > round_robin in sbitmap") > > [3] commit <3301bc53358a> ("lib/sbitmap: kill 'depth' from sbitmap_word") > > > > Without the patchset, the sbitmapq won't work. > > Good job! The patchset looks nice and clean to me, tested ok with > some kernels up to 5.18. Applied with some small adjustments. > > No problem. Thanks > > btw, do you want to use the "<commid id>" style in crash's commit log? > > I think it's not so common, so removed the brackets this time. > > > Oh, I copied the "<commit id>" from another place. But you could feel free to adjust or remove the "<commit id>" from the patch log. I see, please use the common one (without brackets) if no intention :) Thanks, Kazu -- Crash-utility mailing list Crash-utility@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/crash-utility Contribution Guidelines: https://github.com/crash-utility/crash/wiki
