Hi Kazu,
On Wed, Apr 06, 2022 at 02:41:16AM +0000, HAGIO KAZUHITO(萩尾 一仁) wrote:
> > >
> > > diskdump.c: In function ‘read_dump_header’:
> > > diskdump.c:543:10: warning: unused variable ‘bytes_read’ [-Wunused-variable]
> > > ssize_t bytes_read;
> > > ^~~~~~~~~~
> > > diskdump.c:542:9: warning: unused variable ‘len’ [-Wunused-variable]
> > > size_t len;
> > > ^~~
> > > diskdump.c:541:8: warning: unused variable ‘bufptr’ [-Wunused-variable]
> > > char *bufptr;
> > > ^~~~~~
> > Sorry, I did not notice these warnings.
> >
> > Maybe we can add -Werror to the Makefile...
>
> Yes, "make Warn" does this.
By the way, we maybe need to:
1.) add a "make help" for the Makefile..
2.) add more examples about how to use the crash,
such as ram dump.
3.) add a new function to dump a range of page table.
vtop is too simple..
Thanks
Huang Shijie
--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/crash-utility
Contribution Guidelines: https://github.com/crash-utility/crash/wiki
