Re: [PATCH] arm64: use the vmcore info to get module/vmalloc/vmemmap ranges

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Kazu,
On Mon, Mar 14, 2022 at 05:22:37AM +0000, HAGIO KAZUHITO(萩尾 一仁) wrote:
> -----Original Message-----
> > 
> > +/* Return 0 if we succeed, return 1 on failure. */
> > +static int arm64_get_vmcoreinfo_ul(unsigned long *vaddr, const char* label)
> > +{
> > +	char *string = pc->read_vmcoreinfo(label);
> > +
> > +	if (!string)
> > +		return 1;
> > +
> > +	*vaddr  = strtoul(string, NULL, 0);
> > +	free(string);
> > +	return 0;
> 
> The return value is irregular in crash.
> Would you use TRUE on success and FALSE on failure?

Ok, no problem.

Thanks
Huang Shijie

--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/crash-utility
Contribution Guidelines: https://github.com/crash-utility/crash/wiki




[Index of Archives]     [Fedora Development]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]

 

Powered by Linux