On Fri, Mar 11, 2022 at 4:27 PM HAGIO KAZUHITO(萩尾 一仁) <k-hagio-ab@xxxxxxx> wrote:
-----Original Message-----
> v6 --> v7:
> 1.) Simplify the arm64_get_struct_page_max_shift().
> 2.) Add "struct_page_size" dump info in arm64_dump_machdep_table().
> 3.) Tested it again.
Normally the members of machspec are printed after "macspec:" so
with the following change,
Acked-by: Kazuhito Hagio <k-hagio-ab@xxxxxxx>
diff --git a/arm64.c b/arm64.c
index ac8d9e0c24df..2dcef46dc496 100644
--- a/arm64.c
+++ b/arm64.c
@@ -947,7 +947,6 @@ arm64_dump_machdep_table(ulong arg)
fprintf(fp, " pageshift: %d\n", machdep->pageshift);
fprintf(fp, " pagemask: %lx\n", (ulong)machdep->pagemask);
fprintf(fp, " pageoffset: %lx\n", machdep->pageoffset);
- fprintf(fp, " struct_page_size: %ld\n", ms->struct_page_size);
fprintf(fp, " stacksize: %ld\n", machdep->stacksize);
fprintf(fp, " hz: %d\n", machdep->hz);
fprintf(fp, " mhz: %ld\n", machdep->mhz);
@@ -1034,6 +1033,7 @@ arm64_dump_machdep_table(ulong arg)
}
fprintf(fp, " machspec: %lx\n", (ulong)ms);
+ fprintf(fp, " struct_page_size: %ld\n", ms->struct_page_size);
fprintf(fp, " VA_BITS: %ld\n", ms->VA_BITS);
fprintf(fp, " CONFIG_ARM64_VA_BITS: %ld\n", ms->CONFIG_ARM64_VA_BITS);
fprintf(fp, " VA_START: ");
Lianbo, could you please apply with this?
Yes. Good understanding, Kazu.
Thanks,
Kazu
-- Crash-utility mailing list Crash-utility@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/crash-utility Contribution Guidelines: https://github.com/crash-utility/crash/wiki
