Re: [PATCH] Makefile: fix the wrong target "cscope"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Huang Shijie,

-----Original Message-----
> Subject: [PATCH] Makefile: fix the wrong target "cscope"
> 
> The "make cscope" should generate cscope index, not call the cscope.
> Just fix it.

I have not used the cscope target, but I think that only generating
cscope index is a common behavior.  so I agree with this change.

but probably the current one is intentional and I don't think it is
wrong, so with the following subject and commit message,

Acked-by: Kazuhito Hagio <k-hagio-ab@xxxxxxx>
---
Subject: [PATCH] Makefile: Change the behavior of target "cscope"

Make the "make cscope" only generate cscope index, not call the cscope.

Also fix a typo:
	cscope_out --> cscope.out
---

Thanks,
Kazu

> 
> Also fix a typo:
> 	cscope_out --> cscope.out
> 
> Signed-off-by: Huang Shijie <shijie@xxxxxxxxxxxxxxxxxxxxxx>
> ---
>  Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 20b6e31..bf21c2a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -642,10 +642,10 @@ ref:
>  	$(MAKE) ctags cscope
> 
>  cscope:
> -	rm -f cscope.files cscope_out
> +	rm -f cscope.files cscope.out
>  	for FILE in ${SOURCE_FILES}; do \
>  	echo $$FILE >> cscope.files; done
> -	cscope
> +	cscope -b -f cscope.out
> 
>  glink: make_configure
>  	@./configure -q -b
> --
> 2.30.2


--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/crash-utility




[Index of Archives]     [Fedora Development]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]

 

Powered by Linux