On Wed, Jan 12, 2022 at 8:23 AM HAGIO KAZUHITO(萩尾 一仁) <k-hagio-ab@xxxxxxx> wrote: > > -----Original Message----- > > Hi Kazu, > > > > > > HAGIO KAZUHITO(萩尾 一仁) <k-hagio-ab@xxxxxxx> writes: > > > > > Hi Alex, > > > > > > -----Original Message----- > > >> Since linux-next commit fe1e19081321 ("mm: Split slab into its own type"), > > now I can see the commit in upstream with another commit id. > Thanks for the reminder, Alex. :) > > Lianbo, please modify the subject and message like this when merging > after your review: Yesterday, I just saw this commit in the linux branch. And the fix looks good, applied(with the patch log changes). Thanks. Lianbo > --- > Subject: memory: Handle struct slab changes on Linux 5.17-rc1 and later > > Since kernel commit d122019bf061 ("mm: Split slab into its own type"), > ... > > Without the patch, crash fails to start with the error message: > > crash: invalid structure member offset: kmem_cache_s_num > FILE: memory.c LINE: 9619 FUNCTION: kmem_cache_init() > --- > > Thanks, > Kazu > > > >> the struct slab is used for both SLAB and SLUB. Therefore, don't depend > > >> on the non-presence of the struct slab to decide whether SLAB implementation > > >> should be chosen and use the member variable "cpu_slab" of the struct > > >> kmem_cache instead, it should be present only in SLUB. > > >> > > >> Signed-off-by: Alexander Egorenkov <egorenar@xxxxxxxxxxxxx> > > > > > > Thanks for the early fix as always. It looks good to me. > > > We'd like to add the error message to the commit log: > > > --- > > > Without the patch, crash fails to start with the error message: > > > > > > crash: invalid structure member offset: kmem_cache_s_num > > > FILE: memory.c LINE: 9619 FUNCTION: kmem_cache_init() > > > --- > > > > > > Acked-by: Kazuhito Hagio <k-hagio-ab@xxxxxxx> > > > > > > > Thanks! Looks good. > > > > > > > btw, kmem -s does not work well with the current linux-next. > > > I've not looked into it yet, any patches would be helpful. > > > > > > > Thanks for the hint, i'll look into it when i have time, was not aware > > of it. > > > > Regards > > Alex -- Crash-utility mailing list Crash-utility@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/crash-utility