On Thu, Dec 23, 2021 at 5:14 PM <crash-utility-request@xxxxxxxxxx> wrote: > Date: Thu, 23 Dec 2021 00:33:16 +0000 > From: HAGIO KAZUHITO(?????) <k-hagio-ab@xxxxxxx> > To: Sven Schnelle <svens@xxxxxxxxxxxxx> > Cc: "Discussion list for crash utility usage, maintenance and > development" <crash-utility@xxxxxxxxxx> > Subject: Re: [PATCH v2 4/4] make: replace make by > $(MAKE) > Message-ID: > <OS3PR01MB677601D042591DF6451F477DDD7E9@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> > > Content-Type: text/plain; charset="iso-2022-jp" > > Hi Sven, > > thank you for the update. > > -----Original Message----- > > diff --git a/gdb-10.2.patch b/gdb-10.2.patch > > index 1280d0688e83..afdbe99eae0d 100644 > > --- a/gdb-10.2.patch > > +++ b/gdb-10.2.patch > > @@ -73,7 +73,7 @@ > > # Removing the old gdb first works better if it is running, at least on SunOS. > > gdb$(EXEEXT): gdb.o $(LIBGDB_OBS) $(CDEPS) $(TDEPLIBS) > > $(SILENCE) rm -f gdb$(EXEEXT) > > -+ @make -C ../.. GDB_FLAGS=-DGDB_10_2 library > > ++ @$(MAKE) -C ../.. GDB_FLAGS=-DGDB_10_2 library > > $(ECHO_CXXLD) $(CC_LD) $(INTERNAL_LDFLAGS) $(WIN32LDAPP) \ > > - -o gdb$(EXEEXT) gdb.o $(LIBGDB_OBS) \ > > - $(TDEPLIBS) $(TUI_LIBRARY) $(CLIBS) $(LOADLIBES) > > When detecting any change of the gdb patch, it tries to re-apply the new one > using "patch -N --fuzz=0" in order to update the gdb. Please refer to > Makefile::rebuild and the head of the gdb-10.2.patch. > > So I think that, to make a change to the gdb sources, > > 1. we have to "add" patches to the end of the gdb patch, and > 2. if there are multiple patches for a gdb file, the "patch -N" doesn't work, > so we have to revert the gdb file to the original one. > > (I will add this custom to crash guidelines later..) > Good point, Kazu. Thanks. Lianbo -- Crash-utility mailing list Crash-utility@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/crash-utility