-----Original Message----- > > On 2021/12/16 4:01 PM, HAGIO KAZUHITO(萩尾 一仁) wrote: > > -----Original Message----- > >> Since the xen_start_info on the arm/arm64 platform is static defined: > >> > >> ./arm/xen/enlighten.c:40:static struct start_info _xen_start_info; > >> ./arm/xen/enlighten.c:41:struct start_info *xen_start_info = &_xen_start_info; > >> ./arm/xen/enlighten.c:42:EXPORT_SYMBOL(xen_start_info); > >> > >> The is_pvops_xen() in commit 4badc6229c69f5cd9da7eb7bdf400a53ec6db01a > >> ("Fix pvops Xen detection for kernels >= v4.20") always return TRUE. > >> Then the following error will be reported because p2m_mid_missing > >> and xen_p2m_addr are not defined: > >> > >> crash: cannot resolve "p2m_top" > >> > >> For the arm/arm64 platform, fix it by using xen_vcpu_info instead of > >> xen_start_info to detect Xen dumps. > >> > >> Signed-off-by: Qi Zheng <zhengqi.arch@xxxxxxxxxxxxx> > > > > I cannot test it on arm, but the patch looks good to me. > > > > Acked-by: Kazuhito Hagio <k-hagio-ab@xxxxxxx> > > Thanks. I see that it takes at least two Acked-bys to be merged into the > mainline, so anyone else has any comments? Hi Qi, Lianbo will merge or comment after his review, please wait for a while. Thanks, Kazu -- Crash-utility mailing list Crash-utility@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/crash-utility