-----Original Message-----
>
> On Fri, 2021-08-20 at 01:26 +0000, HAGIO KAZUHITO(萩尾 一仁) wrote:
> > -----Original Message-----
> > > Dear Kazu,
> > >
> > > Sorry for late reply
> > > Thanks for your suggestion and I have prepared a V2 patch, please
> > > help
> > > to review.
> >
> > ok, I've modified your v2 patch to fix the following compilation
> > warning
> > and rewrite the commit log, and attached it.
> >
> > arm64.c: In function ‘arm64_init’:
> > arm64.c:3728:35: warning: ‘note’ may be used uninitialized in this
> > function [-Wmaybe-uninitialized]
>
>
>
> This warning can be eliminated as follows:
> --- a/arm64.c
> +++ b/arm64.c
> @@ -3698,14 +3698,48 @@ arm64_get_crash_notes(void)
> {
> struct machine_specific *ms = machdep->machspec;
> ulong crash_notes;
> - Elf64_Nhdr *note;
> + Elf64_Nhdr *note = NULL;
> ulong offset;
>
>
> But I didn't see this correction in V2. Can you help to add the initialization of the note variable Kazu.
> Otherwise:
> Acked-by: Lianbo Jiang <lijiang@xxxxxxxxxx <mailto:lijiang@xxxxxxxxxx> >
Yes, I sent this v3:
https://listman.redhat.com/archives/crash-utility/2021-August/msg00020.html
Attachment: 0001-arm64-Get-CPU-registers-from-ELF-notes-even-without-.patch
(That .bin file can be opened as a plain text file.)
Applied it:
https://github.com/crash-utility/crash/commit/4b34197508578bb43639e6d169fb91fb0489fa2b
Thanks,
Kazu
>
> BTW: the patch format is still unfriendly to me.
>
> Thanks
> Lianbo
>
>
> > offset = roundup(offset + note->n_namesz, 4);
> > ^~
> > Kazu, thanks for your kind help.
>
> > Lianbo, could you review the attached patch?
> >
> > Thanks,
> > Kazu
>
>
>
--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/crash-utility
