On Fri 2021-07-16 07:32 +0000, HAGIO KAZUHITO(萩尾 一仁) wrote: Kazu, > Thanks for the update. No problem. > > + for (i = 0; i < kt->cpus; i++) > > + if (NUM_IN_BITMAP(cpus, i) && check_offline_cpu(i)) > > + error(INFO, "CPU %d is OFFLINE.\n", i); > > With the offline hide option, "CPU xx [OFFLINE]" is shown as follows and > this error message is not needed. > > crash> set offline hide > offline: hide > crash> kmem -S=15 TCP > kmem: CPU 15 is OFFLINE. > CACHE OBJSIZE ALLOCATED TOTAL SLABS SSIZE NAME > ffff916f6798b2c0 2440 17 208 16 32k TCP > CPU 15 [OFFLINE] > ... The above was indeed intentional (to be more verbose) since the CPU(s) is/are explicitly specified by the user. > And the other commands do not say anything by default (offline show), > it should be the same behavior with them. Fair enough. Better to remain consistent. > So with removing the for block above, (but you don't need to repost) > Acked-by: Kazuhito Hagio <k-hagio-ab@xxxxxxx> Understood and thank you. Kind regards, -- Aaron Tomlin
Attachment:
signature.asc
Description: PGP signature
-- Crash-utility mailing list Crash-utility@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/crash-utility
