-----Original Message----- > This series fix the bug caused by arm64 kernel memory layout changes The patchset was very hard to review for me, maybe because of its fixing order? The 2/4 patch uses PAGE_OFFSET but it is changed by 4/4 finally, I'm not sure what is fixed and why it can be fixed by 2/4. so it might be easier to review if it fixes them in order like: 1) fix for PAGE_OFFSET issue on 5.4 and later 2) fix for physvirt_offset loss on 5.10 and later. But you don't have to rewrite it, just an idea. And as you know, I cannot test arm64 crash, please let me know about things I missed. Thanks, Kazu > > v7 -> v8: > [1/4]: use machdep->flags instead of a field in machspec > [2/4]: show FLIPPED_VM and HAS_PHYSVIRT_OFFSET in "help -m " > > Cc: HAGIO KAZUHITO <k-hagio-ab@xxxxxxx> > Cc: Lianbo Jiang <lijiang@xxxxxxxxxx> > Cc: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx> > To: crash-utility@xxxxxxxxxx > Pingfan Liu (4): > crash-utility/arm64: introduce a dedicated field to record the mem > layout changes > crash-utility/arm64: store phy_offset and memstart_addr separately > crash-utility/arm64: rename ARM64_PAGE_OFFSET_ACTUAL as > ARM64_FLIP_PAGE_OFFSET_ACTUAL > crash-utility/arm64: assign page_offset with kernel configure value > > arm64.c | 93 +++++++++++++++++++++++++++++++++++++++++++++++++++------ > defs.h | 24 +++++++++++---- > 2 files changed, 102 insertions(+), 15 deletions(-) > > -- > 2.29.2 -- Crash-utility mailing list Crash-utility@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/crash-utility
