Re: [PATCH v2] Fix 'waitq' command for 4.13 and later kernels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



-----Original Message-----
> > > Maybe we should keep the original changes:
> > > -             return;
> > > +             error(FATAL, "cannot determine wait queue structure\n");
> > >
> > > And fix the warnings directly in the kernel.c(dump_waitq()) as below:
> > >
> > > -       ulong task_offset;              /* offset of task in wq element */
> > > +       ulong task_offset = 0;          /* offset of task in wq element */
> > >         int cnt;                        /* # elems on Queue */
> > > -       int start_index;                /* where to start in wq array */
> > > +       int start_index = -1;           /* where to start in wq array */
> >
> > OK, I see.  Let's go with this reasonable fix.
> >
> Thanks, Kazu.
> 
> For v2 with the warning fix: Acked-by: Lianbo Jiang <lijang@xxxxxxxxxx>

Applied with the fix above:
https://github.com/crash-utility/crash/commit/eaf14f852ae79f7745934e213661f1c6abac711e

Thanks,
Kazu


--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/crash-utility




[Index of Archives]     [Fedora Development]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]

 

Powered by Linux