Re: [PATCH 2/2] diskdump: Print total number of dumpable pages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 08, 2021 at 06:28:51AM +0000, HAGIO KAZUHITO(萩尾 一仁) wrote:
> > @@ -2090,6 +2094,7 @@ __diskdump_memory_dump(FILE *fp)
> >  	else
> >  		fprintf(fp, "\n");
> >  	fprintf(fp, "       valid_pages: %lx\n", (ulong)dd->valid_pages);
> > +	fprintf(fp, " total_valid_pages: %lx\n", dd->total_valid_pages);
> 
> I'd like to use %ld for this, will change.

Yes, it makes sense. I'll fix it in v2.

Thanks,
Roman

> Otherwise, the 2/2 patch looks good to me.
> 
> Acked-by: Kazuhito Hagio <k-hagio-ab@xxxxxxx>
> 
> Thanks,
> Kazu
> 


--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/crash-utility




[Index of Archives]     [Fedora Development]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]

 

Powered by Linux