-----Original Message-----
> By the previous commit, trying to read swapped-out-into-zram-disk
> pages results in inaccessible memory error that is apparently
> irrelevant to zram and users cannot find it necessary to load zram
> module. Thus, let's add a warning message to indicate that.
>
> Signed-off-by: HATAYAMA Daisuke <d.hatayama@xxxxxxxxxxx>
> ---
> diskdump.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/diskdump.c b/diskdump.c
> index 304e9a1..cdbc2d5 100644
> --- a/diskdump.c
> +++ b/diskdump.c
> @@ -2751,8 +2751,13 @@ try_zram_decompress(ulonglong pte_val, unsigned char *buf, ulong len, ulonglong
>
> if (INVALID_MEMBER(zram_compressor)) {
> zram_init();
> - if (INVALID_MEMBER(zram_compressor))
> + if (INVALID_MEMBER(zram_compressor)) {
> + error(WARNING,
> + "Some pages are swapped out to zram. "
> + "Please load zram module.\n",
> + name);
Hi Hatayama-san,
Only a slight thing from me, this "name" looks unnecessary.
Otherwise, except for the compilation issue, looks good to me.
Thanks!
Kazu
--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/crash-utility
