On 5/6/2019 11:26 AM, Dave Anderson wrote:
>
>
> ----- Original Message -----
>> Hi Dave,
>>
>> I wanted to see net->flags for a vmcore and could see it with "help -N"
>> option. But it is not listed in the help option list, which is printed
>> by "help help" command. Is it just missed?
>>
>> Also, I found that -g, -O and -z options are missing from the list, too.
>> I think it might be helpful for some users to add the -g and -z options
>> to it, but I'm not sure whether the -O option should be added.
>
> The -g and -N options should be added, and although -z is essentially a
> shortened version of "help help", I suppose it could be added as well.
>
> However, the -O option is a remnant from many years ago when I attempted
> to allow the creation of a file of kernel-version-specific offsets, sizes,
> etc, from a vmlinux file built with -g, and then subsequently using that
> file with a stripped vmlinux file of the same version. (It was an idea
> from back in the RHEL2.1 days, which released a vmlinux file that was
> stripped of debuginfo data.) Anyway, that code was never truly functional,
> and is just leftover cruft.
Thank you for the detail, I understood.
Then the patch below would be enough?
Thanks,
Kazu
>
> Thanks,
> Dave
>
>>
>> Signed-off-by: Kazuhito Hagio <k-hagio@xxxxxxxxxxxxx>
>> ---
>> help.c | 6 ++++++
>> net.c | 2 +-
>> 2 files changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/help.c b/help.c
>> index f4ac1baf94b6..c0c750f8f39f 100644
>> --- a/help.c
>> +++ b/help.c
>> @@ -647,6 +647,7 @@ cmd_help(void)
>> fprintf(fp, " -D - dumpfile contents/statistics\n");
>> fprintf(fp, " -e - extension table data\n");
>> fprintf(fp, " -f - filesys table\n");
>> + fprintf(fp, " -g - gdb data\n");
>> fprintf(fp, " -h - hash_table data\n");
>> fprintf(fp, " -H - hash_table data (verbose)\n");
>> fprintf(fp, " -k - kernel_table\n");
>> @@ -654,6 +655,7 @@ cmd_help(void)
>> fprintf(fp, " -L - LKCD page cache environment\n");
>> fprintf(fp, " -M <num> machine specific\n");
>> fprintf(fp, " -m - machdep_table\n");
>> + fprintf(fp, " -N - net_table\n");
>> fprintf(fp, " -n - dumpfile contents/statistics\n");
>> fprintf(fp, " -o - offset_table and size_table\n");
>> fprintf(fp, " -p - program_context\n");
>> @@ -664,6 +666,7 @@ cmd_help(void)
>> fprintf(fp, " -v - vm_table\n");
>> fprintf(fp, " -V - vm_table (verbose)\n");
>> fprintf(fp, " -x - text cache\n");
>> + fprintf(fp, " -z - help options\n");
>> return;
>>
>> case 'L':
>> @@ -1004,6 +1007,7 @@ char *help_help[] = {
>> " -D - dumpfile contents/statistics",
>> " -e - extension table data",
>> " -f - filesys table",
>> +" -g - gdb data",
>> " -h - hash_table data",
>> " -H - hash_table data (verbose)",
>> " -k - kernel_table",
>> @@ -1011,6 +1015,7 @@ char *help_help[] = {
>> " -L - LKCD page cache environment",
>> " -M <num> machine specific",
>> " -m - machdep_table",
>> +" -N - net_table",
>> " -n - dumpfile contents/statistics",
>> " -o - offset_table and size_table",
>> " -p - program_context",
>> @@ -1021,6 +1026,7 @@ char *help_help[] = {
>> " -v - vm_table",
>> " -V - vm_table (verbose)",
>> " -x - text cache",
>> +" -z - help options",
>> NULL
>> };
>>
>> diff --git a/net.c b/net.c
>> index f08f22a2c833..7c9c8bd9c98d 100644
>> --- a/net.c
>> +++ b/net.c
>> @@ -1279,7 +1279,7 @@ dump_hw_addr(unsigned char *ha, int len)
>> }
>>
>> /*
>> - * help -n output
>> + * help -N output
>> */
>> void
>> dump_net_table(void)
>> --
>> 2.18.1
>>
>>
>
> --
> Crash-utility mailing list
> Crash-utility@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/crash-utility
>
--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/crash-utility
