I've managed to instigate clang to build some pieces of crash-utility code, and it showed unpleasant things which I'd like to bring into your attention. The patch bomb contains only minor nitpicks to check whether I should continue with doing this kind of nasty job further using static analysis tools, various compilers and common sense. Oleksandr Natalenko (14): tools: fix non-literal NULL conversion memory: do not compare unsigned expression with negative value memory: use & for a bitwise operation task: remove extra parentheses in equality comparison x86_64: clarify logical operator precedence lkcd_v1: address of an array always evaluates to true lkcd_v2_v3: address of an array always evaluates to true lkcd_v5: address of an array always evaluates to true lkcd_v7: address of an array always evaluates to true lkcd_v8: address of an array always evaluates to true qemu-load: remove unused function get_le64() sadump: block_size is always non-negative task: format string should be never empty symbols: format string should be never empty lkcd_v1.c | 2 +- lkcd_v2_v3.c | 2 +- lkcd_v5.c | 2 +- lkcd_v7.c | 2 +- lkcd_v8.c | 2 +- memory.c | 8 ++++---- qemu-load.c | 8 -------- sadump.c | 3 --- symbols.c | 9 +++++---- task.c | 20 +++++++++++--------- tools.c | 2 +- x86_64.c | 4 ++-- 12 files changed, 28 insertions(+), 36 deletions(-) -- 2.14.3 -- Crash-utility mailing list Crash-utility@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/crash-utility
