----- Original Message ----- > Hi Dave, > > I've uploaded new patch: > https://raw.githubusercontent.com/hziSot/crash-patches/master/crash_speed_up_tree_list.patch > > Thanks, > Alexandr Hi Alexandr, Right from the get-go, this patch needs to be reworked to maintain backwards-compability w/respect to pre-existing users of the list_data structure, and by extension, the do_list(), do_rbtree() and do_rdtree() functions, which may be used by pre-existing extension modules. While you do maintain the original -s options to both the list and tree commands, you rip out the structure members the original data structures used, and the simple code pieces that used them. So I can't accept that kind of change. Can you please make it so the original structname and structname_args members will still be used by the -s options, and segregate your newly added functionality? You can still add stuff to the end of exported list_data and tree_data structures. Thanks, Dave > ________________________________________ > From: crash-utility-bounces@xxxxxxxxxx <crash-utility-bounces@xxxxxxxxxx> on > behalf of Dave Anderson <anderson@xxxxxxxxxx> > Sent: Monday, August 15, 2016 20:34 > To: Discussion list for crash utility usage, maintenance and development > Subject: Re: Fwd: RE: [PATCH 1/1] Speed up list/tree '-s' > output. > > ----- Original Message ----- > > > > From: Dave Anderson <anderson@xxxxxxxxxxxx> > > Date: 07/26/2016 7:24 AM (GMT-08:00) > > To: Alexandr Terekhov <Alexandr_Terekhov@xxxxxxxx> > > Subject: RE: [PATCH 1/1] Speed up list/tree '-s' output. > > > > Hi Alexandr, > > > > I'm on vacation until August 8th, so I won't be able to check this patch > > out > > until later in that week. > > > > Thanks, > > Dave > > > > Alexandr, > > Please repost against the most recent git repo: > > $ git clone git://github.com/crash-utility/crash.git > Cloning into 'crash'... > remote: Counting objects: 1470, done. > remote: Total 1470 (delta 0), reused 0 (delta 0), pack-reused 1470 > Receiving objects: 100% (1470/1470), 4.07 MiB | 2.40 MiB/s, done. > Resolving deltas: 100% (924/924), done. > $ cd crash > $ patch -p1 < $dl/tree-s.patch > patching file tools.c > Hunk #2 FAILED at 3230. > Hunk #3 succeeded at 3247 with fuzz 1. > Hunk #5 FAILED at 3481. > Hunk #7 FAILED at 3535. > Hunk #8 succeeded at 3588 with fuzz 1. > Hunk #9 succeeded at 3688 with fuzz 1. > Hunk #13 FAILED at 3893. > Hunk #14 FAILED at 3901. > Hunk #15 FAILED at 4026. > Hunk #16 FAILED at 4101. > Hunk #17 succeeded at 4136 (offset 2 lines). > 7 out of 17 hunks FAILED -- saving rejects to file tools.c.rej > patching file defs.h > Hunk #1 FAILED at 2376. > Hunk #2 succeeded at 2388 with fuzz 2 (offset 5 lines). > Hunk #3 succeeded at 2414 (offset 5 lines). > 1 out of 3 hunks FAILED -- saving rejects to file defs.h.rej > patching file help.c > Hunk #1 FAILED at 5583. > 1 out of 1 hunk FAILED -- saving rejects to file help.c.rej > $ > > Thanks, > Dave > > > > > -- > Crash-utility mailing list > Crash-utility@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/crash-utility > > -- > Crash-utility mailing list > Crash-utility@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/crash-utility > -- Crash-utility mailing list Crash-utility@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/crash-utility
