Hello Dave,
I have detected some issues on sadump caused by the commit:
https://github.com/crash-utility/crash/commit/5e887f898c709f912686addde1e046dd1639c97b
Could you apply two fixing patches?
--
Thanks.
HATAYAMA, Daisuke
>From 92c42f20016040633fdc99f1606b6460e518640f Mon Sep 17 00:00:00 2001
From: HATAYAMA Daisuke <d.hatayama@xxxxxxxxxxxxxx>
Date: Mon, 21 Dec 2015 13:40:48 +0900
Subject: [PATCH 1/2] Fix for set command on sadump related formats not
reflecting the actual internal state of zero excluded mode as on/off value in
zero_excluded column.
Signed-off-by: HATAYAMA Daisuke <d.hatayama@xxxxxxxxxxxxxx>
---
tools.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools.c b/tools.c
index f7c5b4c..afc6cb3 100644
--- a/tools.c
+++ b/tools.c
@@ -2520,7 +2520,9 @@ show_options(void)
fprintf(fp, " namelist: %s\n", pc->namelist);
fprintf(fp, " dumpfile: %s\n", pc->dumpfile);
fprintf(fp, " unwind: %s\n", kt->flags & DWARF_UNWIND ? "on" : "off");
- fprintf(fp, " zero_excluded: %s\n", *diskdump_flags & ZERO_EXCLUDED ? "on" : "off");
+ fprintf(fp, " zero_excluded: %s\n",
+ (*diskdump_flags & ZERO_EXCLUDED) || sadump_is_zero_excluded() ?
+ "on" : "off");
fprintf(fp, " null-stop: %s\n", *gdb_stop_print_at_null ? "on" : "off");
fprintf(fp, " gdb: %s\n", pc->flags2 & GDB_CMD_MODE ? "on" : "off");
fprintf(fp, " scope: %lx ", pc->scope);
--
1.9.3
>From f02ffc131933a8da8e516b2558c0945873ea290d Mon Sep 17 00:00:00 2001
From: HATAYAMA Daisuke <d.hatayama@xxxxxxxxxxxxxx>
Date: Fri, 18 Dec 2015 10:59:57 +0900
Subject: [PATCH 2/2] Switch to zero excluded mode by default on sadump-related
formats. This is a fix for the regression, introduced by the commit
5e887f898c709f912686addde1e046dd1639c97b, that zero excluded mode is disabled
in the beginning of crash initialization process, making some Fujitsu
troubleshooting software not work.
Signed-off-by: HATAYAMA Daisuke <d.hatayama@xxxxxxxxxxxxxx>
---
sadump.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/sadump.c b/sadump.c
index 7cad15a..a96ba9c 100644
--- a/sadump.c
+++ b/sadump.c
@@ -394,7 +394,13 @@ restart:
}
sd->filename = file;
- sd->flags = flags;
+
+ /*
+ * Switch to zero excluded mode by default on sadump-related
+ * formats because some Fujitsu troubleshooting software
+ * assumes the behavior.
+ */
+ sd->flags = flags | SADUMP_ZERO_EXCLUDED;
if (machine_type("X86"))
sd->machine_type = EM_386;
--
1.9.3
--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/crash-utility
