----- Original Message ----- > Dave, > > thanks for the review and here is the new patch. changes from the last > version. > > * add GPL license header > * remove stdbool.h > * complete function declaration > * add header file dependency in Makefile. > * fit VMWARE_VMSS to flag. > > addition to the source file change, > * vmss file samples. > for vSphere ESX, memory dump is part of the vmss file; > for VMware Workstation, memory dump stores in a companion vmem file. > > https://www.dropbox.com/sh/fe8cdwxg1mw97or/AADSDfKDc8dHgh2AIBrMJE1za?dl=0 > - CentOS6.5-11bd56db.vmss - CentOS6.5/vSphere 5.5 > kernel-debuginfo-2.6.32-431.el6.x86_64.rpm - symbol > kernel-debuginfo-common-x86_64-2.6.32-431.el6.x86_64.rpm - source > > - Ubuntu1404_64bit-65993542.vmss - Ubuntu14.04/Workstation 11 > Ubuntu1404_64bit-65993542.vmem - companion memory dump > linux-image-3.13.0-39-generic-dbgsym_3.13.0-39.66_amd64.ddeb - symbol > > - run_crash.sh > > * vmss parser - the internal structure of a vmss file. > - https://github.com/dyno/vmss.scripts/blob/master/vmss_construct.py > > rgds, > Dyno Hello Dyno, I added just one other minor change to fix up the debug fprintf's in vmware_vmss_init() for a clean "make warn" comile on 32-bit hosts. Queued for crash-7.1.0: https://github.com/crash-utility/crash/commit/f7e429764056d10e0ae87921e722e4e703cfb362 Nice addition to the supported dumpfile family. Thanks, Dave -- Crash-utility mailing list Crash-utility@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/crash-utility
