Re: [RFC PATCH 1/2] crash: Show memory overcommit data in dump_kmeminfo()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri 2014-11-21 15:50 -0500, Dave Anderson wrote:
> Sure enough, in a 2.6.30 kernel, which has no "sysctl_overcommit_kbytes", I get
> a SIGFPE on this line:
> 
>                        pct = committed ? ((committed * 100)
>                                         / allowed) : 0;
> 
> because sysctl_overcommit_kbytes doesn't exist.  I don't know what 
> the initial setting should be, because certainly 0 won't work.

OK - I've changed the logic so that if "sysctl_overcommit_kbytes" does not
exist or if set to 0, then we fall back to using "sysctl_overcommit_ratio"
in the calculation for "allowed" as per normal.

-- 
Aaron Tomlin

--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/crash-utility




[Index of Archives]     [Fedora Development]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]

 

Powered by Linux