[PATCH] kdump: fix to get the correct page at the edge of split files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Dave,

I found a bug when analyzing split vmcore in kdump-compressed format.
Please check the patch.

--
Regards
Qiao Nuohan
>From 608f336603326adf40bfdb8234a79bfe60b757db Mon Sep 17 00:00:00 2001
From: Qiao Nuohan <qiaonuohan@xxxxxxxxxxxxxx>
Date: Wed, 29 Oct 2014 15:54:31 +0800
Subject: [PATCH] kdump: fix to get the correct page at the edge of split files

the end_pfn means the last pfn of the split, but actually it is not included in
the split. So we should not get the data of end_pfn from the current split.

Signed-off-by: Qiao Nuohan <qiaonuohan@xxxxxxxxxxxxxx>
---
 diskdump.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/diskdump.c b/diskdump.c
index 7639e32..4857bcc 100644
--- a/diskdump.c
+++ b/diskdump.c
@@ -1094,7 +1094,7 @@ read_diskdump(int fd, void *bufptr, int cnt, ulong addr, physaddr_t paddr)
 		for (i=0; i<num_dumpfiles; i++) {
 			start_pfn = dd_list[i]->sub_header_kdump->start_pfn_64;
 			end_pfn = dd_list[i]->sub_header_kdump->end_pfn_64;
-			if ((pfn >= start_pfn) && (pfn <= end_pfn))	{
+			if ((pfn >= start_pfn) && (pfn < end_pfn))	{
 				dd = dd_list[i];
 				break;
 			}
-- 
1.8.5.3

--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/crash-utility

[Index of Archives]     [Fedora Development]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]

 

Powered by Linux